object_store/util.rs
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245
// Copyright 2023 Greptime Team
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
use std::fmt::Display;
use common_telemetry::{debug, error, trace};
use opendal::layers::{LoggingInterceptor, LoggingLayer, TracingLayer};
use opendal::raw::{AccessorInfo, Operation};
use opendal::ErrorKind;
use crate::ObjectStore;
/// Join two paths and normalize the output dir.
///
/// The output dir is always ends with `/`. e.g.
/// - `/a/b` join `c` => `/a/b/c/`
/// - `/a/b` join `/c/` => `/a/b/c/`
///
/// All internal `//` will be replaced by `/`.
pub fn join_dir(parent: &str, child: &str) -> String {
// Always adds a `/` to the output path.
let output = format!("{parent}/{child}/");
normalize_dir(&output)
}
/// Modified from the `opendal::raw::normalize_root`
///
/// # The different
///
/// It doesn't always append `/` ahead of the path,
/// It only keeps `/` ahead if the original path starts with `/`.
///
/// Make sure the directory is normalized to style like `abc/def/`.
///
/// # Normalize Rules
///
/// - All whitespace will be trimmed: ` abc/def ` => `abc/def`
/// - All leading / will be trimmed: `///abc` => `abc`
/// - Internal // will be replaced by /: `abc///def` => `abc/def`
/// - Empty path will be `/`: `` => `/`
/// - **(Removed❗️)** ~~Add leading `/` if not starts with: `abc/` => `/abc/`~~
/// - Add trailing `/` if not ends with: `/abc` => `/abc/`
///
/// Finally, we will got path like `/path/to/root/`.
pub fn normalize_dir(v: &str) -> String {
let has_root = v.starts_with('/');
let mut v = v
.split('/')
.filter(|v| !v.is_empty())
.collect::<Vec<&str>>()
.join("/");
if has_root {
v.insert(0, '/');
}
if !v.ends_with('/') {
v.push('/')
}
v
}
/// Push `child` to `parent` dir and normalize the output path.
///
/// - Path endswith `/` means it's a dir path.
/// - Otherwise, it's a file path.
pub fn join_path(parent: &str, child: &str) -> String {
let output = format!("{parent}/{child}");
normalize_path(&output)
}
/// Make sure all operation are constructed by normalized path:
///
/// - Path endswith `/` means it's a dir path.
/// - Otherwise, it's a file path.
///
/// # Normalize Rules
///
/// - All whitespace will be trimmed: ` abc/def ` => `abc/def`
/// - Repeated leading / will be trimmed: `///abc` => `/abc`
/// - Internal // will be replaced by /: `abc///def` => `abc/def`
/// - Empty path will be `/`: `` => `/`
pub fn normalize_path(path: &str) -> String {
// - all whitespace has been trimmed.
let path = path.trim();
// Fast line for empty path.
if path.is_empty() {
return "/".to_string();
}
let has_leading = path.starts_with('/');
let has_trailing = path.ends_with('/');
let mut p = path
.split('/')
.filter(|v| !v.is_empty())
.collect::<Vec<_>>()
.join("/");
// If path is not starting with `/` but it should
if !p.starts_with('/') && has_leading {
p.insert(0, '/');
}
// If path is not ending with `/` but it should
if !p.ends_with('/') && has_trailing {
p.push('/');
}
p
}
/// Attaches instrument layers to the object store.
pub fn with_instrument_layers(object_store: ObjectStore, path_label: bool) -> ObjectStore {
object_store
.layer(LoggingLayer::new(DefaultLoggingInterceptor))
.layer(TracingLayer)
.layer(crate::layers::build_prometheus_metrics_layer(path_label))
}
static LOGGING_TARGET: &str = "opendal::services";
struct LoggingContext<'a>(&'a [(&'a str, &'a str)]);
impl Display for LoggingContext<'_> {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
for (i, (k, v)) in self.0.iter().enumerate() {
if i > 0 {
write!(f, " {}={}", k, v)?;
} else {
write!(f, "{}={}", k, v)?;
}
}
Ok(())
}
}
#[derive(Debug, Copy, Clone, Default)]
pub struct DefaultLoggingInterceptor;
impl LoggingInterceptor for DefaultLoggingInterceptor {
#[inline]
fn log(
&self,
info: &AccessorInfo,
operation: Operation,
context: &[(&str, &str)],
message: &str,
err: Option<&opendal::Error>,
) {
if let Some(err) = err {
// Print error if it's unexpected, otherwise in error.
if err.kind() == ErrorKind::Unexpected {
error!(
target: LOGGING_TARGET,
"service={} name={} {}: {operation} {message} {err:#?}",
info.scheme(),
info.name(),
LoggingContext(context),
);
} else {
debug!(
target: LOGGING_TARGET,
"service={} name={} {}: {operation} {message} {err}",
info.scheme(),
info.name(),
LoggingContext(context),
);
};
}
// Print debug message if operation is oneshot, otherwise in trace.
if operation.is_oneshot() {
debug!(
target: LOGGING_TARGET,
"service={} name={} {}: {operation} {message}",
info.scheme(),
info.name(),
LoggingContext(context),
);
} else {
trace!(
target: LOGGING_TARGET,
"service={} name={} {}: {operation} {message}",
info.scheme(),
info.name(),
LoggingContext(context),
);
};
}
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn test_normalize_dir() {
assert_eq!("/", normalize_dir("/"));
assert_eq!("/", normalize_dir(""));
assert_eq!("/test/", normalize_dir("/test"));
}
#[test]
fn test_join_dir() {
assert_eq!("/", join_dir("", ""));
assert_eq!("/", join_dir("/", ""));
assert_eq!("/", join_dir("", "/"));
assert_eq!("/", join_dir("/", "/"));
assert_eq!("/a/", join_dir("/a", ""));
assert_eq!("a/b/c/", join_dir("a/b", "c"));
assert_eq!("/a/b/c/", join_dir("/a/b", "c"));
assert_eq!("/a/b/c/", join_dir("/a/b", "c/"));
assert_eq!("/a/b/c/", join_dir("/a/b", "/c/"));
assert_eq!("/a/b/c/", join_dir("/a/b", "//c"));
}
#[test]
fn test_join_path() {
assert_eq!("/", join_path("", ""));
assert_eq!("/", join_path("/", ""));
assert_eq!("/", join_path("", "/"));
assert_eq!("/", join_path("/", "/"));
assert_eq!("a/", join_path("a", ""));
assert_eq!("/a", join_path("/", "a"));
assert_eq!("a/b/c.txt", join_path("a/b", "c.txt"));
assert_eq!("/a/b/c.txt", join_path("/a/b", "c.txt"));
assert_eq!("/a/b/c/", join_path("/a/b", "c/"));
assert_eq!("/a/b/c/", join_path("/a/b", "/c/"));
assert_eq!("/a/b/c.txt", join_path("/a/b", "//c.txt"));
assert_eq!("abc/def", join_path(" abc", "/def "));
assert_eq!("/abc", join_path("//", "/abc"));
assert_eq!("abc/def", join_path("abc/", "//def"));
}
}