common_meta/rpc/

router.rs

// Copyright 2023 Greptime Team
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//     http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

use std::collections::{BTreeMap, HashMap, HashSet};

use common_time::util::current_time_millis;
use derive_builder::Builder;
use serde::ser::SerializeSeq;
use serde::{Deserialize, Deserializer, Serialize, Serializer};
use store_api::region_engine::RegionRole;
use store_api::storage::{RegionId, RegionNumber};
use strum::AsRefStr;

use crate::DatanodeId;
use crate::key::RegionDistribution;
use crate::peer::Peer;

/// Returns the distribution of regions to datanodes.
///
/// The distribution is a map of datanode id to a list of region ids.
/// The list of region ids is sorted in ascending order.
pub fn region_distribution(region_routes: &[RegionRoute]) -> RegionDistribution {
    let mut regions_id_map = RegionDistribution::new();
    for route in region_routes.iter() {
        if let Some(peer) = route.leader_peer.as_ref() {
            let region_number = route.region.id.region_number();
            regions_id_map
                .entry(peer.id)
                .or_default()
                .add_leader_region(region_number);
        }
        for peer in route.follower_peers.iter() {
            let region_number = route.region.id.region_number();
            regions_id_map
                .entry(peer.id)
                .or_default()
                .add_follower_region(region_number);
        }
    }
    for region_role_set in regions_id_map.values_mut() {
        // Sort the regions in ascending order.
        region_role_set.sort()
    }
    regions_id_map
}

/// Returns the leader peers of the table.
pub fn find_leaders(region_routes: &[RegionRoute]) -> HashSet<Peer> {
    region_routes
        .iter()
        .flat_map(|x| &x.leader_peer)
        .cloned()
        .collect()
}

/// Returns the followers of the table.
pub fn find_followers(region_routes: &[RegionRoute]) -> HashSet<Peer> {
    region_routes
        .iter()
        .flat_map(|x| &x.follower_peers)
        .cloned()
        .collect()
}

/// Returns the operating leader regions with corresponding [DatanodeId].
pub fn operating_leader_regions(region_routes: &[RegionRoute]) -> Vec<(RegionId, DatanodeId)> {
    region_routes
        .iter()
        .filter_map(|route| {
            route
                .leader_peer
                .as_ref()
                .map(|leader| (route.region.id, leader.id))
        })
        .collect::<Vec<_>>()
}

/// Returns the operating leader regions with corresponding [DatanodeId] and [RegionRole].
pub fn operating_leader_region_roles(
    region_routes: &[RegionRoute],
) -> Vec<(RegionId, DatanodeId, RegionRole)> {
    region_routes
        .iter()
        .filter_map(|route| {
            let role = route.leader_region_role()?;
            let leader = route.leader_peer.as_ref()?;
            Some((route.region.id, leader.id, role))
        })
        .collect()
}

/// Returns the HashMap<[RegionNumber], &[Peer]>;
///
/// If the region doesn't have a leader peer, the [Region] will be omitted.
pub fn convert_to_region_leader_map(region_routes: &[RegionRoute]) -> HashMap<RegionNumber, &Peer> {
    region_routes
        .iter()
        .filter_map(|x| {
            x.leader_peer
                .as_ref()
                .map(|leader| (x.region.id.region_number(), leader))
        })
        .collect::<HashMap<_, _>>()
}

/// Returns the leader of the first route matching the region number.
pub fn find_region_leader(
    region_routes: &[RegionRoute],
    region_number: RegionNumber,
) -> Option<Peer> {
    find_region_leader_ref(region_routes, region_number).cloned()
}

/// Borrows the leader of the first route matching the region number.
///
/// Returns `None` if no route matches or the first matching route has no leader.
pub fn find_region_leader_ref(
    region_routes: &[RegionRoute],
    region_number: RegionNumber,
) -> Option<&Peer> {
    region_routes
        .iter()
        .find(|x| x.region.id.region_number() == region_number)
        .and_then(|r| r.leader_peer.as_ref())
}

/// Returns the region numbers of the leader regions on the target datanode.
pub fn find_leader_regions(region_routes: &[RegionRoute], datanode: &Peer) -> Vec<RegionNumber> {
    region_routes
        .iter()
        .filter_map(|x| {
            if let Some(peer) = &x.leader_peer
                && peer == datanode
            {
                return Some(x.region.id.region_number());
            }
            None
        })
        .collect()
}

/// Returns the region numbers of the follower regions on the target datanode.
pub fn find_follower_regions(region_routes: &[RegionRoute], datanode: &Peer) -> Vec<RegionNumber> {
    region_routes
        .iter()
        .filter_map(|x| {
            if x.follower_peers.contains(datanode) {
                return Some(x.region.id.region_number());
            }
            None
        })
        .collect()
}

#[derive(Debug, Clone, Default, Deserialize, Serialize, PartialEq, Builder)]
pub struct RegionRoute {
    pub region: Region,
    #[builder(setter(into, strip_option))]
    pub leader_peer: Option<Peer>,
    #[builder(setter(into), default)]
    pub follower_peers: Vec<Peer>,
    /// `None` by default.
    #[builder(setter(into, strip_option), default)]
    #[serde(
        default,
        alias = "leader_status",
        skip_serializing_if = "Option::is_none"
    )]
    pub leader_state: Option<LeaderState>,
    /// The start time when the leader is in `Downgraded` state.
    #[serde(default)]
    #[builder(default = "self.default_leader_down_since()")]
    pub leader_down_since: Option<i64>,
    /// Special write routing behavior for this region.
    #[builder(setter(into, strip_option), default)]
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub write_route_policy: Option<WriteRoutePolicy>,
}

impl RegionRouteBuilder {
    fn default_leader_down_since(&self) -> Option<i64> {
        match self.leader_state {
            Some(Some(LeaderState::Downgrading)) => Some(current_time_millis()),
            _ => None,
        }
    }
}

/// The State of the [`Region`] Leader.
/// TODO(dennis): It's better to add more fine-grained statuses such as `PENDING` etc.
#[derive(Debug, Clone, Copy, Deserialize, Serialize, PartialEq, AsRefStr)]
#[strum(serialize_all = "UPPERCASE")]
pub enum LeaderState {
    /// The following cases in which the [`Region`] will be downgraded.
    ///
    /// - The [`Region`] may be unavailable (e.g., Crashed, Network disconnected).
    /// - The [`Region`] was planned to migrate to another [`Peer`].
    #[serde(alias = "Downgraded")]
    Downgrading,
    /// The [`Region`] is in staging mode.
    ///
    /// Disables checkpoint and compaction while maintaining write capability.
    /// But data ingested during this period are not visible to the user (hence staging).
    Staging,
}

/// The write route policy for the region.
#[derive(Debug, Clone, Copy, Deserialize, Serialize, PartialEq, Eq)]
pub enum WriteRoutePolicy {
    // The default policy.
    Normal,
    /// Ignores all writes for this region.
    ///
    /// This policy is typically used during region merge operations, such as repartitioning.
    /// For example, when merging Region A and Region B into just Region B,
    /// writes to Region A are ignored, while Region B accepts all writes originating from both regions.
    IgnoreAllWrites,
}

impl RegionRoute {
    /// Returns true if the region should ignore all writes.
    pub fn is_ignore_all_writes(&self) -> bool {
        matches!(
            self.write_route_policy,
            Some(WriteRoutePolicy::IgnoreAllWrites)
        )
    }

    /// Marks this region as ignore-all for writes.
    pub fn set_ignore_all_writes(&mut self) {
        self.write_route_policy = Some(WriteRoutePolicy::IgnoreAllWrites);
    }

    /// Clears ignore-all write policy and falls back to normal routing behavior.
    pub fn clear_ignore_all_writes(&mut self) {
        if self.write_route_policy == Some(WriteRoutePolicy::IgnoreAllWrites) {
            self.write_route_policy = None;
        }
    }

    /// Returns true if the Leader [`Region`] is downgraded.
    ///
    /// The following cases in which the [`Region`] will be downgraded.
    ///
    /// - The [`Region`] is unavailable(e.g., Crashed, Network disconnected).
    /// - The [`Region`] was planned to migrate to another [`Peer`].
    ///
    pub fn is_leader_downgrading(&self) -> bool {
        matches!(self.leader_state, Some(LeaderState::Downgrading))
    }

    /// Returns true if the Leader [`Region`] is in staging mode.
    pub fn is_leader_staging(&self) -> bool {
        matches!(self.leader_state, Some(LeaderState::Staging))
    }

    /// Returns the role of the leader region.
    pub fn leader_region_role(&self) -> Option<RegionRole> {
        self.leader_peer.as_ref().map(|_| {
            if self.is_leader_staging() {
                RegionRole::StagingLeader
            } else if self.is_leader_downgrading() {
                RegionRole::DowngradingLeader
            } else {
                RegionRole::Leader
            }
        })
    }

    /// Marks the Leader [`Region`] as [`RegionState::Downgrading`].
    ///
    /// We should downgrade a [`Region`] before deactivating it:
    ///
    /// - During the [`Region`] Failover Procedure.
    /// - Migrating a [`Region`].
    ///
    /// **Notes:** Meta Server will renewing a special lease(`Downgrading`) for the downgrading [`Region`].
    ///
    /// A downgrading region will reject any write requests, and only allow memetable to be flushed to object storage
    ///
    pub fn downgrade_leader(&mut self) {
        self.leader_down_since = Some(current_time_millis());
        self.leader_state = Some(LeaderState::Downgrading)
    }

    /// Sets the Leader [`Region`] to staging mode.
    pub fn set_leader_staging(&mut self) {
        self.leader_state = Some(LeaderState::Staging);
        // Reset leader_down_since as it's specific to downgrading
        self.leader_down_since = None;
    }

    /// Clears the leader staging state, returning to normal leader mode.
    pub fn clear_leader_staging(&mut self) {
        if self.leader_state == Some(LeaderState::Staging) {
            self.leader_state = None;
            self.leader_down_since = None;
        }
    }

    /// Returns how long since the leader is in `Downgraded` state.
    pub fn leader_down_millis(&self) -> Option<i64> {
        self.leader_down_since
            .map(|start| current_time_millis() - start)
    }

    /// Sets the leader state.
    ///
    /// Returns true if updated.
    pub fn set_leader_state(&mut self, state: Option<LeaderState>) -> bool {
        let updated = self.leader_state != state;

        match (state, updated) {
            (Some(LeaderState::Downgrading), true) => {
                self.leader_down_since = Some(current_time_millis());
            }
            (Some(LeaderState::Downgrading), false) => {
                // Do nothing if leader is still in `Downgraded` state.
            }
            _ => {
                self.leader_down_since = None;
            }
        }

        self.leader_state = state;
        updated
    }
}

#[derive(Debug, Clone, Default, PartialEq, Serialize)]
pub struct Region {
    pub id: RegionId,
    pub name: String,
    pub attrs: BTreeMap<String, String>,
    /// The normalized partition expression of the region.
    pub partition_expr: String,
}

#[derive(Debug, Deserialize)]
struct RegionDe {
    id: RegionId,
    name: String,
    #[serde(default)]
    attrs: BTreeMap<String, String>,
    #[serde(default)]
    partition: Option<LegacyPartition>,
    #[serde(default)]
    partition_expr: String,
}

impl<'de> Deserialize<'de> for Region {
    fn deserialize<D>(deserializer: D) -> std::result::Result<Self, D::Error>
    where
        D: Deserializer<'de>,
    {
        let de = RegionDe::deserialize(deserializer)?;
        // Compatibility path for legacy serialized routes: prefer the normalized
        // `partition_expr` field and only fall back to legacy `partition.value_list`.
        let partition_expr = if de.partition_expr.is_empty() {
            if let Some(LegacyPartition { value_list, .. }) = &de.partition {
                value_list
                    .first()
                    .map(|expr| String::from_utf8_lossy(expr).to_string())
                    .unwrap_or_default()
            } else {
                String::new()
            }
        } else {
            de.partition_expr
        };

        Ok(Self {
            id: de.id,
            name: de.name,
            attrs: de.attrs,
            partition_expr,
        })
    }
}

impl Region {
    #[cfg(any(test, feature = "testing"))]
    pub fn new_test(id: RegionId) -> Self {
        Self {
            id,
            ..Default::default()
        }
    }

    /// Gets the partition expression of the region in compatible mode.
    pub fn partition_expr(&self) -> String {
        self.partition_expr.clone()
    }
}

#[derive(Debug, Clone, Deserialize, Serialize, PartialEq)]
pub struct LegacyPartition {
    #[serde(serialize_with = "as_utf8_vec", deserialize_with = "from_utf8_vec")]
    pub column_list: Vec<Vec<u8>>,
    #[serde(serialize_with = "as_utf8_vec", deserialize_with = "from_utf8_vec")]
    pub value_list: Vec<Vec<u8>>,
}

fn as_utf8_vec<S: Serializer>(
    val: &[Vec<u8>],
    serializer: S,
) -> std::result::Result<S::Ok, S::Error> {
    let mut seq = serializer.serialize_seq(Some(val.len()))?;
    for v in val {
        seq.serialize_element(&String::from_utf8_lossy(v))?;
    }
    seq.end()
}

pub fn from_utf8_vec<'de, D>(deserializer: D) -> std::result::Result<Vec<Vec<u8>>, D::Error>
where
    D: Deserializer<'de>,
{
    let values = Vec::<String>::deserialize(deserializer)?;

    let values = values
        .into_iter()
        .map(|value| value.into_bytes())
        .collect::<Vec<_>>();
    Ok(values)
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::key::RegionRoleSet;

    fn new_test_region_route(region_id: RegionId) -> RegionRoute {
        RegionRoute {
            region: Region::new_test(region_id),
            leader_peer: Some(Peer::new(1, "a1")),
            follower_peers: vec![Peer::new(2, "a2")],
            leader_state: None,
            leader_down_since: None,
            write_route_policy: None,
        }
    }

    #[test]
    fn test_find_region_leader() {
        let mut routes = vec![
            new_test_region_route(RegionId::new(1, 1)),
            new_test_region_route(RegionId::new(1, 1)),
        ];
        routes[1].leader_peer = Some(Peer::new(2, "a2"));

        assert_eq!(
            find_region_leader_ref(&routes, 1),
            routes[0].leader_peer.as_ref()
        );
        assert_eq!(find_region_leader(&routes, 1), routes[0].leader_peer);
        assert_eq!(find_region_leader_ref(&routes, 2), None);
        assert_eq!(find_region_leader(&routes, 2), None);

        routes[0].leader_peer = None;
        assert_eq!(find_region_leader_ref(&routes, 1), None);
        assert_eq!(find_region_leader(&routes, 1), None);
    }

    #[test]
    fn test_leader_is_downgraded() {
        let mut region_route = RegionRoute {
            region: Region {
                id: 2.into(),
                name: "r2".to_string(),
                attrs: BTreeMap::new(),
                partition_expr: "".to_string(),
            },
            leader_peer: Some(Peer::new(1, "a1")),
            follower_peers: vec![Peer::new(2, "a2"), Peer::new(3, "a3")],
            leader_state: None,
            leader_down_since: None,
            write_route_policy: None,
        };

        assert!(!region_route.is_leader_downgrading());

        region_route.downgrade_leader();

        assert!(region_route.is_leader_downgrading());
    }

    #[test]
    fn test_region_route_decode() {
        let region_route = RegionRoute {
            region: Region {
                id: 2.into(),
                name: "r2".to_string(),
                attrs: BTreeMap::new(),
                partition_expr: "".to_string(),
            },
            leader_peer: Some(Peer::new(1, "a1")),
            follower_peers: vec![Peer::new(2, "a2"), Peer::new(3, "a3")],
            leader_state: None,
            leader_down_since: None,
            write_route_policy: None,
        };

        let input = r#"{"region":{"id":2,"name":"r2","partition":null,"attrs":{}},"leader_peer":{"id":1,"addr":"a1"},"follower_peers":[{"id":2,"addr":"a2"},{"id":3,"addr":"a3"}]}"#;

        let decoded: RegionRoute = serde_json::from_str(input).unwrap();

        assert_eq!(decoded, region_route);
    }

    #[test]
    fn test_region_route_compatibility() {
        let region_route = RegionRoute {
            region: Region {
                id: 2.into(),
                name: "r2".to_string(),
                attrs: BTreeMap::new(),
                partition_expr: "".to_string(),
            },
            leader_peer: Some(Peer::new(1, "a1")),
            follower_peers: vec![Peer::new(2, "a2"), Peer::new(3, "a3")],
            leader_state: Some(LeaderState::Downgrading),
            leader_down_since: None,
            write_route_policy: None,
        };
        let input = r#"{"region":{"id":2,"name":"r2","partition":null,"attrs":{}},"leader_peer":{"id":1,"addr":"a1"},"follower_peers":[{"id":2,"addr":"a2"},{"id":3,"addr":"a3"}],"leader_state":"Downgraded","leader_down_since":null}"#;
        let decoded: RegionRoute = serde_json::from_str(input).unwrap();
        assert_eq!(decoded, region_route);

        let region_route = RegionRoute {
            region: Region {
                id: 2.into(),
                name: "r2".to_string(),
                attrs: BTreeMap::new(),
                partition_expr: "".to_string(),
            },
            leader_peer: Some(Peer::new(1, "a1")),
            follower_peers: vec![Peer::new(2, "a2"), Peer::new(3, "a3")],
            leader_state: Some(LeaderState::Downgrading),
            leader_down_since: None,
            write_route_policy: None,
        };
        let input = r#"{"region":{"id":2,"name":"r2","partition":null,"attrs":{}},"leader_peer":{"id":1,"addr":"a1"},"follower_peers":[{"id":2,"addr":"a2"},{"id":3,"addr":"a3"}],"leader_status":"Downgraded","leader_down_since":null}"#;
        let decoded: RegionRoute = serde_json::from_str(input).unwrap();
        assert_eq!(decoded, region_route);

        let region_route = RegionRoute {
            region: Region {
                id: 2.into(),
                name: "r2".to_string(),
                attrs: BTreeMap::new(),
                partition_expr: "".to_string(),
            },
            leader_peer: Some(Peer::new(1, "a1")),
            follower_peers: vec![Peer::new(2, "a2"), Peer::new(3, "a3")],
            leader_state: Some(LeaderState::Downgrading),
            leader_down_since: None,
            write_route_policy: None,
        };
        let input = r#"{"region":{"id":2,"name":"r2","partition":null,"attrs":{}},"leader_peer":{"id":1,"addr":"a1"},"follower_peers":[{"id":2,"addr":"a2"},{"id":3,"addr":"a3"}],"leader_state":"Downgrading","leader_down_since":null}"#;
        let decoded: RegionRoute = serde_json::from_str(input).unwrap();
        assert_eq!(decoded, region_route);

        let region_route = RegionRoute {
            region: Region {
                id: 2.into(),
                name: "r2".to_string(),
                attrs: BTreeMap::new(),
                partition_expr: "".to_string(),
            },
            leader_peer: Some(Peer::new(1, "a1")),
            follower_peers: vec![Peer::new(2, "a2"), Peer::new(3, "a3")],
            leader_state: Some(LeaderState::Downgrading),
            leader_down_since: None,
            write_route_policy: None,
        };
        let input = r#"{"region":{"id":2,"name":"r2","partition":null,"attrs":{}},"leader_peer":{"id":1,"addr":"a1"},"follower_peers":[{"id":2,"addr":"a2"},{"id":3,"addr":"a3"}],"leader_status":"Downgrading","leader_down_since":null}"#;
        let decoded: RegionRoute = serde_json::from_str(input).unwrap();
        assert_eq!(decoded, region_route);
    }

    #[test]
    fn test_region_route_write_route_policy_decode_compatibility() {
        let input = r#"{"region":{"id":2,"name":"r2","partition":null,"attrs":{}},"leader_peer":{"id":1,"addr":"a1"},"follower_peers":[{"id":2,"addr":"a2"}],"write_route_policy":"IgnoreAllWrites"}"#;
        let decoded: RegionRoute = serde_json::from_str(input).unwrap();

        assert!(decoded.is_ignore_all_writes());
    }

    #[test]
    fn test_region_route_write_route_policy_default_not_serialized() {
        let region_route = RegionRoute {
            region: Region {
                id: 2.into(),
                name: "r2".to_string(),
                attrs: BTreeMap::new(),
                partition_expr: "".to_string(),
            },
            leader_peer: Some(Peer::new(1, "a1")),
            follower_peers: vec![Peer::new(2, "a2"), Peer::new(3, "a3")],
            leader_state: None,
            leader_down_since: None,
            write_route_policy: None,
        };

        let encoded = serde_json::to_string(&region_route).unwrap();
        assert!(!encoded.contains("write_route_policy"));
    }

    #[test]
    fn test_region_route_write_route_policy_helpers() {
        let mut region_route = RegionRoute {
            region: Region::new_test(2.into()),
            leader_peer: Some(Peer::new(1, "a1")),
            follower_peers: vec![],
            leader_state: None,
            leader_down_since: None,
            write_route_policy: None,
        };

        assert!(!region_route.is_ignore_all_writes());
        region_route.set_ignore_all_writes();
        assert!(region_route.is_ignore_all_writes());
        region_route.clear_ignore_all_writes();
        assert!(!region_route.is_ignore_all_writes());
    }

    #[test]
    fn test_leader_region_role_without_leader_peer_returns_none() {
        let region_route = RegionRoute {
            leader_peer: None,
            ..new_test_region_route(RegionId::new(1, 1))
        };

        assert_eq!(region_route.leader_region_role(), None);
    }

    #[test]
    fn test_leader_region_role_variants() {
        let normal = new_test_region_route(RegionId::new(1, 1));
        let mut downgrading = new_test_region_route(RegionId::new(1, 2));
        downgrading.leader_state = Some(LeaderState::Downgrading);
        let mut staging = new_test_region_route(RegionId::new(1, 3));
        staging.leader_state = Some(LeaderState::Staging);

        assert_eq!(normal.leader_region_role(), Some(RegionRole::Leader));
        assert_eq!(
            downgrading.leader_region_role(),
            Some(RegionRole::DowngradingLeader)
        );
        assert_eq!(
            staging.leader_region_role(),
            Some(RegionRole::StagingLeader)
        );
    }

    #[test]
    fn test_operating_leader_region_roles_returns_expected_roles() {
        let no_leader_region = RegionRoute {
            leader_peer: None,
            ..new_test_region_route(RegionId::new(1, 4))
        };
        let mut downgrading = new_test_region_route(RegionId::new(1, 2));
        downgrading.leader_peer = Some(Peer::new(2, "a2"));
        downgrading.leader_state = Some(LeaderState::Downgrading);
        let mut staging = new_test_region_route(RegionId::new(1, 3));
        staging.leader_peer = Some(Peer::new(3, "a3"));
        staging.leader_state = Some(LeaderState::Staging);

        let roles = operating_leader_region_roles(&[
            new_test_region_route(RegionId::new(1, 1)),
            downgrading,
            staging,
            no_leader_region,
        ]);

        assert_eq!(
            roles,
            vec![
                (RegionId::new(1, 1), 1, RegionRole::Leader),
                (RegionId::new(1, 2), 2, RegionRole::DowngradingLeader),
                (RegionId::new(1, 3), 3, RegionRole::StagingLeader),
            ]
        );
    }

    #[test]
    fn test_region_distribution() {
        let region_routes = vec![
            RegionRoute {
                region: Region {
                    id: RegionId::new(1, 1),
                    name: "r1".to_string(),
                    attrs: BTreeMap::new(),
                    partition_expr: "".to_string(),
                },
                leader_peer: Some(Peer::new(1, "a1")),
                follower_peers: vec![Peer::new(2, "a2"), Peer::new(3, "a3")],
                leader_state: None,
                leader_down_since: None,
                write_route_policy: None,
            },
            RegionRoute {
                region: Region {
                    id: RegionId::new(1, 2),
                    name: "r2".to_string(),
                    attrs: BTreeMap::new(),
                    partition_expr: "".to_string(),
                },
                leader_peer: Some(Peer::new(2, "a2")),
                follower_peers: vec![Peer::new(1, "a1"), Peer::new(3, "a3")],
                leader_state: None,
                leader_down_since: None,
                write_route_policy: None,
            },
        ];

        let distribution = region_distribution(&region_routes);
        assert_eq!(distribution.len(), 3);
        assert_eq!(distribution[&1], RegionRoleSet::new(vec![1], vec![2]));
        assert_eq!(distribution[&2], RegionRoleSet::new(vec![2], vec![1]));
        assert_eq!(distribution[&3], RegionRoleSet::new(vec![], vec![1, 2]));
    }

    #[test]
    fn test_de_serialize_partition() {
        let p = LegacyPartition {
            column_list: vec![b"a".to_vec(), b"b".to_vec()],
            value_list: vec![b"hi".to_vec(), b",".to_vec()],
        };

        let output = serde_json::to_string(&p).unwrap();
        let got: LegacyPartition = serde_json::from_str(&output).unwrap();

        assert_eq!(got, p);
    }
}