common_grpc_expr/

alter.rs

// Copyright 2023 Greptime Team
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//     http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

use api::helper::ColumnDataTypeWrapper;
use api::v1::add_column_location::LocationType;
use api::v1::alter_table_expr::Kind;
use api::v1::column_def::{
    as_fulltext_option_analyzer, as_fulltext_option_backend, as_skipping_index_type,
};
use api::v1::{
    AddColumnLocation as Location, AlterTableExpr, Analyzer, CreateTableExpr, DropColumns,
    FulltextBackend as PbFulltextBackend, ModifyColumnTypes, RenameTable, SemanticType,
    SkippingIndexType as PbSkippingIndexType, column_def,
};
use common_query::AddColumnLocation;
use datatypes::json::{JsonSettings, JsonTypeHint};
use datatypes::prelude::ConcreteDataType;
use datatypes::schema::{ColumnSchema, FulltextOptions, Schema, SkippingIndexOptions};
use snafu::{OptionExt, ResultExt, ensure};
use store_api::region_request::{SetRegionOption, UnsetRegionOption};
use table::metadata::{TableId, TableMeta};
use table::requests::{
    AddColumnRequest, AlterKind, AlterTableRequest, AnnotationFamily, ModifyColumnTypeRequest,
    SetDefaultRequest, SetIndexOption, SetJsonSettingsRequest, UnsetIndexOption,
};

use crate::error::{
    self, ColumnNotFoundSnafu, InvalidColumnDefSnafu, InvalidIndexOptionSnafu,
    InvalidJsonSettingsSnafu, InvalidSetFulltextOptionRequestSnafu,
    InvalidSetSkippingIndexOptionRequestSnafu, InvalidSetTableOptionRequestSnafu,
    InvalidUnsetTableOptionRequestSnafu, MissingAlterIndexOptionSnafu, MissingFieldSnafu,
    MissingTableMetaSnafu, MissingTimestampColumnSnafu, Result, UnknownLocationTypeSnafu,
};

const LOCATION_TYPE_FIRST: i32 = LocationType::First as i32;
const LOCATION_TYPE_AFTER: i32 = LocationType::After as i32;

/// Classifies a SET/UNSET key batch: `Ok(Some(family))` when every key belongs
/// to the same annotation family, `Ok(None)` when none does, and an error on a
/// mixed batch — annotation alters skip region dispatch, so they cannot share
/// a statement with options that regions must see.
fn annotation_family_of_keys<'a>(
    keys: impl Iterator<Item = &'a str>,
) -> Result<Option<AnnotationFamily>> {
    table::requests::validate_annotation_keys(keys).map_err(|err| {
        error::InvalidTableOptionRequestSnafu {
            err_msg: err.to_string(),
        }
        .build()
    })
}

fn json_settings_from_proto(settings: api::v1::JsonSettings) -> Result<JsonSettings> {
    let type_hints = settings
        .type_hints
        .into_iter()
        .map(|hint| {
            let data_type = ConcreteDataType::from(
                ColumnDataTypeWrapper::try_new(hint.data_type, hint.datatype_extension)
                    .context(error::ColumnDataTypeSnafu)?,
            );

            Ok(JsonTypeHint {
                path: hint.path,
                data_type,
                // Index configuration is not supported yet, so this is temporarily
                // hardcoded to false.
                inverted_index: false,
            })
        })
        .collect::<Result<Vec<_>>>()?;

    JsonSettings::try_new(type_hints, settings.max_auto_expanded_paths).map_err(|err| {
        InvalidJsonSettingsSnafu {
            err: err.to_string(),
        }
        .build()
    })
}

/// Returns the annotation family when `kind` is a SET/UNSET whose keys all
/// belong to one family — the alters that only rewrite table metadata and skip
/// region dispatch. A mixed batch is an error; never interpret it as "not an
/// annotation alter", or the batch falls through to a path that reports a
/// misleading error (or dispatches to regions).
pub fn annotation_alter_family(kind: &Kind) -> Result<Option<AnnotationFamily>> {
    match kind {
        Kind::SetTableOptions(api::v1::SetTableOptions { table_options }) => {
            annotation_family_of_keys(table_options.iter().map(|option| option.key.as_str()))
        }
        Kind::UnsetTableOptions(api::v1::UnsetTableOptions { keys }) => {
            annotation_family_of_keys(keys.iter().map(|key| key.as_str()))
        }
        _ => Ok(None),
    }
}

fn set_index_option_from_proto(set_index: api::v1::SetIndex) -> Result<SetIndexOption> {
    let options = set_index.options.context(MissingAlterIndexOptionSnafu)?;
    Ok(match options {
        api::v1::set_index::Options::Fulltext(f) => SetIndexOption::Fulltext {
            column_name: f.column_name.clone(),
            options: FulltextOptions::new(
                f.enable,
                as_fulltext_option_analyzer(
                    Analyzer::try_from(f.analyzer).context(InvalidSetFulltextOptionRequestSnafu)?,
                ),
                f.case_sensitive,
                as_fulltext_option_backend(
                    PbFulltextBackend::try_from(f.backend)
                        .context(InvalidSetFulltextOptionRequestSnafu)?,
                ),
                f.granularity as u32,
                f.false_positive_rate,
            )
            .context(InvalidIndexOptionSnafu)?,
        },
        api::v1::set_index::Options::Inverted(i) => SetIndexOption::Inverted {
            column_name: i.column_name,
        },
        api::v1::set_index::Options::Skipping(s) => SetIndexOption::Skipping {
            column_name: s.column_name,
            options: SkippingIndexOptions::new(
                s.granularity as u32,
                s.false_positive_rate,
                as_skipping_index_type(
                    PbSkippingIndexType::try_from(s.skipping_index_type)
                        .context(InvalidSetSkippingIndexOptionRequestSnafu)?,
                ),
            )
            .context(InvalidIndexOptionSnafu)?,
        },
    })
}

fn unset_index_option_from_proto(unset_index: api::v1::UnsetIndex) -> Result<UnsetIndexOption> {
    let options = unset_index.options.context(MissingAlterIndexOptionSnafu)?;
    Ok(match options {
        api::v1::unset_index::Options::Fulltext(f) => UnsetIndexOption::Fulltext {
            column_name: f.column_name,
        },
        api::v1::unset_index::Options::Inverted(i) => UnsetIndexOption::Inverted {
            column_name: i.column_name,
        },
        api::v1::unset_index::Options::Skipping(s) => UnsetIndexOption::Skipping {
            column_name: s.column_name,
        },
    })
}

/// Convert an [`AlterTableExpr`] to an [`AlterTableRequest`]
///
/// note: `table_meta` must not be None if [`AlterTableExpr`] is `SetDefault`
pub fn alter_expr_to_request(
    table_id: TableId,
    expr: AlterTableExpr,
    table_meta: Option<&TableMeta>,
) -> Result<AlterTableRequest> {
    let catalog_name = expr.catalog_name;
    let schema_name = expr.schema_name;
    let kind = expr.kind.context(MissingFieldSnafu { field: "kind" })?;
    let alter_kind = match kind {
        Kind::AddColumns(add_columns) => {
            let add_column_requests = add_columns
                .add_columns
                .into_iter()
                .map(|ac| {
                    let column_def = ac.column_def.context(MissingFieldSnafu {
                        field: "column_def",
                    })?;

                    let schema = column_def::try_as_column_schema(&column_def).context(
                        InvalidColumnDefSnafu {
                            column: &column_def.name,
                        },
                    )?;
                    Ok(AddColumnRequest {
                        column_schema: schema,
                        is_key: column_def.semantic_type == SemanticType::Tag as i32,
                        location: parse_location(ac.location)?,
                        add_if_not_exists: ac.add_if_not_exists,
                    })
                })
                .collect::<Result<Vec<_>>>()?;

            AlterKind::AddColumns {
                columns: add_column_requests,
            }
        }
        Kind::ModifyColumnTypes(ModifyColumnTypes {
            modify_column_types,
        }) => {
            let modify_column_type_requests = modify_column_types
                .into_iter()
                .map(|cct| {
                    let target_type =
                        ColumnDataTypeWrapper::new(cct.target_type(), cct.target_type_extension)
                            .into();

                    Ok(ModifyColumnTypeRequest {
                        column_name: cct.column_name,
                        target_type,
                    })
                })
                .collect::<Result<Vec<_>>>()?;

            AlterKind::ModifyColumnTypes {
                columns: modify_column_type_requests,
            }
        }
        Kind::SetJsonSettings(set_json_settings) => {
            let settings = set_json_settings
                .settings
                .context(MissingFieldSnafu { field: "settings" })?;
            AlterKind::SetJsonSettings {
                request: SetJsonSettingsRequest {
                    column_name: set_json_settings.column_name,
                    settings: json_settings_from_proto(settings)?,
                },
            }
        }
        Kind::DropColumns(DropColumns { drop_columns }) => AlterKind::DropColumns {
            names: drop_columns.into_iter().map(|c| c.name).collect(),
        },
        Kind::RenameTable(RenameTable { new_table_name }) => {
            AlterKind::RenameTable { new_table_name }
        }
        Kind::SetTableOptions(api::v1::SetTableOptions { table_options }) => {
            if let Some(family) = annotation_family_of_keys(
                table_options.iter().map(|option| option.key.as_str()),
            )? {
                AlterKind::SetAnnotations {
                    family,
                    options: table_options
                        .into_iter()
                        .map(|option| (option.key, option.value))
                        .collect(),
                }
            } else {
                AlterKind::SetTableOptions {
                    options: table_options
                        .iter()
                        .map(SetRegionOption::try_from)
                        .collect::<std::result::Result<Vec<_>, _>>()
                        .context(InvalidSetTableOptionRequestSnafu)?,
                }
            }
        }
        Kind::UnsetTableOptions(api::v1::UnsetTableOptions { keys }) => {
            if let Some(family) = annotation_family_of_keys(keys.iter().map(|key| key.as_str()))? {
                AlterKind::UnsetAnnotations { family, keys }
            } else {
                AlterKind::UnsetTableOptions {
                    keys: keys
                        .iter()
                        .map(|key| UnsetRegionOption::try_from(key.as_str()))
                        .collect::<std::result::Result<Vec<_>, _>>()
                        .context(InvalidUnsetTableOptionRequestSnafu)?,
                }
            }
        }
        Kind::SetIndex(o) => {
            let option = set_index_option_from_proto(o)?;
            AlterKind::SetIndexes {
                options: vec![option],
            }
        }
        Kind::UnsetIndex(o) => {
            let option = unset_index_option_from_proto(o)?;
            AlterKind::UnsetIndexes {
                options: vec![option],
            }
        }
        Kind::SetIndexes(o) => {
            let options = o
                .set_indexes
                .into_iter()
                .map(set_index_option_from_proto)
                .collect::<Result<Vec<_>>>()?;
            AlterKind::SetIndexes { options }
        }
        Kind::UnsetIndexes(o) => {
            let options = o
                .unset_indexes
                .into_iter()
                .map(unset_index_option_from_proto)
                .collect::<Result<Vec<_>>>()?;
            AlterKind::UnsetIndexes { options }
        }
        Kind::DropDefaults(o) => {
            let names = o
                .drop_defaults
                .into_iter()
                .map(|col| {
                    ensure!(
                        !col.column_name.is_empty(),
                        MissingFieldSnafu {
                            field: "column_name"
                        }
                    );
                    Ok(col.column_name)
                })
                .collect::<Result<Vec<_>>>()?;
            AlterKind::DropDefaults { names }
        }
        Kind::SetDefaults(o) => {
            let table_meta = table_meta.context(MissingTableMetaSnafu { table_id })?;
            let defaults = o
                .set_defaults
                .into_iter()
                .map(|col| {
                    let column_scheme = table_meta
                        .schema
                        .column_schema_by_name(&col.column_name)
                        .context(ColumnNotFoundSnafu {
                        column_name: &col.column_name,
                    })?;
                    let default_constraint = common_sql::convert::deserialize_default_constraint(
                        col.default_constraint.as_slice(),
                        &col.column_name,
                        &column_scheme.data_type,
                    )
                    .context(crate::error::SqlCommonSnafu)?;
                    Ok(SetDefaultRequest {
                        column_name: col.column_name,
                        default_constraint,
                    })
                })
                .collect::<Result<Vec<_>>>()?;
            AlterKind::SetDefaults { defaults }
        }
        Kind::Repartition(_) => error::UnexpectedSnafu {
            err_msg: "Repartition operation should be handled through DdlManager and not converted to AlterTableRequest",
        }
        .fail()?,
    };

    let request = AlterTableRequest {
        catalog_name,
        schema_name,
        table_name: expr.table_name,
        table_id,
        alter_kind,
        table_version: None,
    };
    Ok(request)
}

pub fn create_table_schema(expr: &CreateTableExpr, require_time_index: bool) -> Result<Schema> {
    let column_schemas = expr
        .column_defs
        .iter()
        .map(|x| {
            column_def::try_as_column_schema(x).context(InvalidColumnDefSnafu { column: &x.name })
        })
        .collect::<Result<Vec<ColumnSchema>>>()?;

    // allow external table schema without the time index
    if require_time_index {
        ensure!(
            column_schemas
                .iter()
                .any(|column| column.name == expr.time_index),
            MissingTimestampColumnSnafu {
                msg: format!("CreateExpr: {expr:?}")
            }
        );
    }

    let column_schemas = column_schemas
        .into_iter()
        .map(|column_schema| {
            if column_schema.name == expr.time_index {
                column_schema.with_time_index(true)
            } else {
                column_schema
            }
        })
        .collect::<Vec<_>>();

    Ok(Schema::new(column_schemas))
}

fn parse_location(location: Option<Location>) -> Result<Option<AddColumnLocation>> {
    match location {
        Some(Location {
            location_type: LOCATION_TYPE_FIRST,
            ..
        }) => Ok(Some(AddColumnLocation::First)),
        Some(Location {
            location_type: LOCATION_TYPE_AFTER,
            after_column_name,
        }) => Ok(Some(AddColumnLocation::After {
            column_name: after_column_name,
        })),
        Some(Location { location_type, .. }) => UnknownLocationTypeSnafu { location_type }.fail(),
        None => Ok(None),
    }
}

#[cfg(test)]
mod tests {
    use api::v1::{
        AddColumn, AddColumns, ColumnDataType, ColumnDef, DropColumn, ModifyColumnType,
        Option as PbOption, SemanticType, SetTableOptions, UnsetTableOptions,
    };
    use datatypes::prelude::ConcreteDataType;
    use table::requests::REPARTITION_COLUMN_HINT_KEY;

    use super::*;

    #[test]
    fn test_alter_expr_to_request() {
        let expr = AlterTableExpr {
            catalog_name: String::default(),
            schema_name: String::default(),
            table_name: "monitor".to_string(),

            kind: Some(Kind::AddColumns(AddColumns {
                add_columns: vec![AddColumn {
                    column_def: Some(ColumnDef {
                        name: "mem_usage".to_string(),
                        data_type: ColumnDataType::Float64 as i32,
                        is_nullable: false,
                        default_constraint: vec![],
                        semantic_type: SemanticType::Field as i32,
                        comment: String::new(),
                        ..Default::default()
                    }),
                    location: None,
                    add_if_not_exists: true,
                }],
            })),
        };

        let alter_request = alter_expr_to_request(1, expr, None).unwrap();
        assert_eq!(alter_request.catalog_name, "");
        assert_eq!(alter_request.schema_name, "");
        assert_eq!("monitor".to_string(), alter_request.table_name);
        let add_column = match alter_request.alter_kind {
            AlterKind::AddColumns { mut columns } => columns.pop().unwrap(),
            _ => unreachable!(),
        };

        assert!(!add_column.is_key);
        assert_eq!("mem_usage", add_column.column_schema.name);
        assert_eq!(
            ConcreteDataType::float64_datatype(),
            add_column.column_schema.data_type
        );
        assert_eq!(None, add_column.location);
        assert!(add_column.add_if_not_exists);
    }

    #[test]
    fn test_alter_expr_with_location_to_request() {
        let expr = AlterTableExpr {
            catalog_name: String::default(),
            schema_name: String::default(),
            table_name: "monitor".to_string(),

            kind: Some(Kind::AddColumns(AddColumns {
                add_columns: vec![
                    AddColumn {
                        column_def: Some(ColumnDef {
                            name: "mem_usage".to_string(),
                            data_type: ColumnDataType::Float64 as i32,
                            is_nullable: false,
                            default_constraint: vec![],
                            semantic_type: SemanticType::Field as i32,
                            comment: String::new(),
                            ..Default::default()
                        }),
                        location: Some(Location {
                            location_type: LocationType::First.into(),
                            after_column_name: String::default(),
                        }),
                        add_if_not_exists: false,
                    },
                    AddColumn {
                        column_def: Some(ColumnDef {
                            name: "cpu_usage".to_string(),
                            data_type: ColumnDataType::Float64 as i32,
                            is_nullable: false,
                            default_constraint: vec![],
                            semantic_type: SemanticType::Field as i32,
                            comment: String::new(),
                            ..Default::default()
                        }),
                        location: Some(Location {
                            location_type: LocationType::After.into(),
                            after_column_name: "ts".to_string(),
                        }),
                        add_if_not_exists: true,
                    },
                ],
            })),
        };

        let alter_request = alter_expr_to_request(1, expr, None).unwrap();
        assert_eq!(alter_request.catalog_name, "");
        assert_eq!(alter_request.schema_name, "");
        assert_eq!("monitor".to_string(), alter_request.table_name);

        let mut add_columns = match alter_request.alter_kind {
            AlterKind::AddColumns { columns } => columns,
            _ => unreachable!(),
        };

        let add_column = add_columns.pop().unwrap();
        assert!(!add_column.is_key);
        assert_eq!("cpu_usage", add_column.column_schema.name);
        assert_eq!(
            ConcreteDataType::float64_datatype(),
            add_column.column_schema.data_type
        );
        assert_eq!(
            Some(AddColumnLocation::After {
                column_name: "ts".to_string()
            }),
            add_column.location
        );
        assert!(add_column.add_if_not_exists);

        let add_column = add_columns.pop().unwrap();
        assert!(!add_column.is_key);
        assert_eq!("mem_usage", add_column.column_schema.name);
        assert_eq!(
            ConcreteDataType::float64_datatype(),
            add_column.column_schema.data_type
        );
        assert_eq!(Some(AddColumnLocation::First), add_column.location);
        assert!(!add_column.add_if_not_exists);
    }

    #[test]
    fn test_modify_column_type_expr() {
        let expr = AlterTableExpr {
            catalog_name: "test_catalog".to_string(),
            schema_name: "test_schema".to_string(),
            table_name: "monitor".to_string(),

            kind: Some(Kind::ModifyColumnTypes(ModifyColumnTypes {
                modify_column_types: vec![ModifyColumnType {
                    column_name: "mem_usage".to_string(),
                    target_type: ColumnDataType::String as i32,
                    target_type_extension: None,
                }],
            })),
        };

        let alter_request = alter_expr_to_request(1, expr, None).unwrap();
        assert_eq!(alter_request.catalog_name, "test_catalog");
        assert_eq!(alter_request.schema_name, "test_schema");
        assert_eq!("monitor".to_string(), alter_request.table_name);

        let mut modify_column_types = match alter_request.alter_kind {
            AlterKind::ModifyColumnTypes { columns } => columns,
            _ => unreachable!(),
        };

        let modify_column_type = modify_column_types.pop().unwrap();
        assert_eq!("mem_usage", modify_column_type.column_name);
        assert_eq!(
            ConcreteDataType::string_datatype(),
            modify_column_type.target_type
        );
    }

    #[test]
    fn test_drop_column_expr() {
        let expr = AlterTableExpr {
            catalog_name: "test_catalog".to_string(),
            schema_name: "test_schema".to_string(),
            table_name: "monitor".to_string(),

            kind: Some(Kind::DropColumns(DropColumns {
                drop_columns: vec![DropColumn {
                    name: "mem_usage".to_string(),
                }],
            })),
        };

        let alter_request = alter_expr_to_request(1, expr, None).unwrap();
        assert_eq!(alter_request.catalog_name, "test_catalog");
        assert_eq!(alter_request.schema_name, "test_schema");
        assert_eq!("monitor".to_string(), alter_request.table_name);

        let mut drop_names = match alter_request.alter_kind {
            AlterKind::DropColumns { names } => names,
            _ => unreachable!(),
        };
        assert_eq!(1, drop_names.len());
        assert_eq!("mem_usage".to_string(), drop_names.pop().unwrap());
    }

    #[test]
    fn test_repartition_hints_together() {
        let keys = [
            REPARTITION_COLUMN_HINT_KEY,
            table::requests::REPARTITION_PARTITION_NUM_HINT_KEY,
        ];
        let options = vec![
            (keys[0].to_string(), "host".to_string()),
            (keys[1].to_string(), "10".to_string()),
        ];
        let set = Kind::SetTableOptions(SetTableOptions {
            table_options: options
                .iter()
                .map(|(key, value)| PbOption {
                    key: key.clone(),
                    value: value.clone(),
                })
                .collect(),
        });
        let unset = Kind::UnsetTableOptions(UnsetTableOptions {
            keys: keys.map(str::to_string).to_vec(),
        });
        for kind in [set, unset] {
            assert_eq!(
                annotation_alter_family(&kind).unwrap(),
                Some(AnnotationFamily::RepartitionHint)
            );
            let request = alter_expr_to_request(
                1,
                AlterTableExpr {
                    kind: Some(kind),
                    ..Default::default()
                },
                None,
            )
            .unwrap();
            match request.alter_kind {
                AlterKind::SetAnnotations {
                    family,
                    options: actual,
                } => {
                    assert_eq!(family, AnnotationFamily::RepartitionHint);
                    assert_eq!(actual, options);
                }
                AlterKind::UnsetAnnotations {
                    family,
                    keys: actual,
                } => {
                    assert_eq!(family, AnnotationFamily::RepartitionHint);
                    assert_eq!(actual, keys);
                }
                other => panic!("unexpected alter kind: {other:?}"),
            }
        }
    }

    #[test]
    fn test_repartition_partition_num_hint_expr() {
        let key = table::requests::REPARTITION_PARTITION_NUM_HINT_KEY;
        let set = Kind::SetTableOptions(SetTableOptions {
            table_options: vec![PbOption {
                key: key.to_string(),
                value: "8".to_string(),
            }],
        });
        let unset = Kind::UnsetTableOptions(UnsetTableOptions {
            keys: vec![key.to_string()],
        });
        for kind in [set, unset] {
            assert_eq!(
                annotation_alter_family(&kind).unwrap(),
                Some(AnnotationFamily::RepartitionHint)
            );
            let request = alter_expr_to_request(
                1,
                AlterTableExpr {
                    kind: Some(kind),
                    ..Default::default()
                },
                None,
            )
            .unwrap();
            match request.alter_kind {
                AlterKind::SetAnnotations { family, options } => {
                    assert_eq!(family, AnnotationFamily::RepartitionHint);
                    assert_eq!(options, vec![(key.to_string(), "8".to_string())]);
                }
                AlterKind::UnsetAnnotations { family, keys } => {
                    assert_eq!(family, AnnotationFamily::RepartitionHint);
                    assert_eq!(keys, vec![key.to_string()]);
                }
                other => panic!("unexpected alter kind: {other:?}"),
            }
        }
        for other in [key, table::requests::TTL_KEY] {
            for kind in [
                Kind::SetTableOptions(SetTableOptions {
                    table_options: [key, other]
                        .into_iter()
                        .map(|key| PbOption {
                            key: key.to_string(),
                            value: "8".to_string(),
                        })
                        .collect(),
                }),
                Kind::UnsetTableOptions(UnsetTableOptions {
                    keys: vec![key.to_string(), other.to_string()],
                }),
            ] {
                assert!(annotation_alter_family(&kind).is_err());
                assert!(
                    alter_expr_to_request(
                        1,
                        AlterTableExpr {
                            kind: Some(kind),
                            ..Default::default()
                        },
                        None
                    )
                    .is_err()
                );
            }
        }
    }

    #[test]
    fn test_set_repartition_column_hint_expr() {
        let expr = AlterTableExpr {
            catalog_name: "test_catalog".to_string(),
            schema_name: "test_schema".to_string(),
            table_name: "monitor".to_string(),
            kind: Some(Kind::SetTableOptions(SetTableOptions {
                table_options: vec![PbOption {
                    key: REPARTITION_COLUMN_HINT_KEY.to_string(),
                    value: "host".to_string(),
                }],
            })),
        };

        let alter_request = alter_expr_to_request(1, expr, None).unwrap();
        match alter_request.alter_kind {
            AlterKind::SetAnnotations { family, options } => {
                assert_eq!(AnnotationFamily::RepartitionHint, family);
                assert_eq!(
                    vec![(REPARTITION_COLUMN_HINT_KEY.to_string(), "host".to_string())],
                    options
                );
            }
            _ => unreachable!(),
        }
    }

    #[test]
    fn test_set_repartition_column_hint_rejects_mixed_options() {
        let expr = AlterTableExpr {
            catalog_name: "test_catalog".to_string(),
            schema_name: "test_schema".to_string(),
            table_name: "monitor".to_string(),
            kind: Some(Kind::SetTableOptions(SetTableOptions {
                table_options: vec![
                    PbOption {
                        key: REPARTITION_COLUMN_HINT_KEY.to_string(),
                        value: "host".to_string(),
                    },
                    PbOption {
                        key: table::requests::TTL_KEY.to_string(),
                        value: "7d".to_string(),
                    },
                ],
            })),
        };

        let err = alter_expr_to_request(1, expr, None).unwrap_err();
        assert!(
            err.to_string()
                .contains("repartition hints must be altered separately")
        );

        // Duplicate hint entries are not a meaningful batch either.
        let dup = AlterTableExpr {
            catalog_name: "test_catalog".to_string(),
            schema_name: "test_schema".to_string(),
            table_name: "monitor".to_string(),
            kind: Some(Kind::SetTableOptions(SetTableOptions {
                table_options: vec![
                    PbOption {
                        key: REPARTITION_COLUMN_HINT_KEY.to_string(),
                        value: "host".to_string(),
                    },
                    PbOption {
                        key: REPARTITION_COLUMN_HINT_KEY.to_string(),
                        value: "region".to_string(),
                    },
                ],
            })),
        };
        let err = alter_expr_to_request(1, dup, None).unwrap_err();
        assert!(err.to_string().contains("duplicate repartition hint keys"));
    }

    #[test]
    fn test_unset_repartition_column_hint_expr() {
        let expr = AlterTableExpr {
            catalog_name: "test_catalog".to_string(),
            schema_name: "test_schema".to_string(),
            table_name: "monitor".to_string(),
            kind: Some(Kind::UnsetTableOptions(UnsetTableOptions {
                keys: vec![REPARTITION_COLUMN_HINT_KEY.to_string()],
            })),
        };

        let alter_request = alter_expr_to_request(1, expr, None).unwrap();
        match alter_request.alter_kind {
            AlterKind::UnsetAnnotations { family, keys } => {
                assert_eq!(AnnotationFamily::RepartitionHint, family);
                assert_eq!(vec![REPARTITION_COLUMN_HINT_KEY.to_string()], keys);
            }
            _ => unreachable!(),
        }
    }

    #[test]
    fn test_semantic_options_classified_as_annotations() {
        let expr = AlterTableExpr {
            catalog_name: "test_catalog".to_string(),
            schema_name: "test_schema".to_string(),
            table_name: "monitor".to_string(),
            kind: Some(Kind::SetTableOptions(SetTableOptions {
                table_options: vec![
                    PbOption {
                        key: "greptime.semantic.signal_type".to_string(),
                        value: "trace".to_string(),
                    },
                    PbOption {
                        key: "greptime.semantic.entity.host.id".to_string(),
                        value: "host".to_string(),
                    },
                ],
            })),
        };

        let alter_request = alter_expr_to_request(1, expr, None).unwrap();
        let AlterKind::SetAnnotations { family, options } = alter_request.alter_kind else {
            panic!(
                "expected SetAnnotations, got {:?}",
                alter_request.alter_kind
            );
        };
        assert_eq!(family, AnnotationFamily::Semantic);
        assert_eq!(options.len(), 2);

        let expr = AlterTableExpr {
            catalog_name: "test_catalog".to_string(),
            schema_name: "test_schema".to_string(),
            table_name: "monitor".to_string(),
            kind: Some(Kind::UnsetTableOptions(UnsetTableOptions {
                keys: vec!["greptime.semantic.signal_type".to_string()],
            })),
        };
        let alter_request = alter_expr_to_request(1, expr, None).unwrap();
        assert!(matches!(
            alter_request.alter_kind,
            AlterKind::UnsetAnnotations {
                family: AnnotationFamily::Semantic,
                ..
            }
        ));
    }

    #[test]
    fn test_semantic_options_reject_mixed_batch() {
        let mixed_set = AlterTableExpr {
            catalog_name: "test_catalog".to_string(),
            schema_name: "test_schema".to_string(),
            table_name: "monitor".to_string(),
            kind: Some(Kind::SetTableOptions(SetTableOptions {
                table_options: vec![
                    PbOption {
                        key: "greptime.semantic.signal_type".to_string(),
                        value: "trace".to_string(),
                    },
                    PbOption {
                        key: table::requests::TTL_KEY.to_string(),
                        value: "7d".to_string(),
                    },
                ],
            })),
        };
        let err = alter_expr_to_request(1, mixed_set, None).unwrap_err();
        assert!(err.to_string().contains("altered separately"), "{err}");

        let mixed_unset = AlterTableExpr {
            catalog_name: "test_catalog".to_string(),
            schema_name: "test_schema".to_string(),
            table_name: "monitor".to_string(),
            kind: Some(Kind::UnsetTableOptions(UnsetTableOptions {
                keys: vec![
                    "ttl".to_string(),
                    "greptime.semantic.signal_type".to_string(),
                ],
            })),
        };
        let err = alter_expr_to_request(1, mixed_unset, None).unwrap_err();
        assert!(err.to_string().contains("altered separately"), "{err}");
    }

    #[test]
    fn test_annotation_alter_family() {
        let mixed = Kind::SetTableOptions(SetTableOptions {
            table_options: vec![
                PbOption {
                    key: "greptime.semantic.signal_type".to_string(),
                    value: "trace".to_string(),
                },
                PbOption {
                    key: "ttl".to_string(),
                    value: "7d".to_string(),
                },
            ],
        });
        let err = annotation_alter_family(&mixed).unwrap_err();
        assert!(
            err.to_string().contains("must be altered separately"),
            "{err}"
        );

        // Two annotation families cannot share a batch either.
        let cross = Kind::SetTableOptions(SetTableOptions {
            table_options: vec![
                PbOption {
                    key: "greptime.semantic.signal_type".to_string(),
                    value: "trace".to_string(),
                },
                PbOption {
                    key: REPARTITION_COLUMN_HINT_KEY.to_string(),
                    value: "host".to_string(),
                },
            ],
        });
        let err = annotation_alter_family(&cross).unwrap_err();
        assert!(
            err.to_string().contains("must be altered separately"),
            "{err}"
        );
    }
}